RFR: 8342818: Implement CPU Time Profiling for JFR [v4]

Johannes Bechberger jbechberger at openjdk.org
Thu Oct 31 06:46:36 UTC 2024


On Thu, 31 Oct 2024 02:54:09 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> And it's far easier to read.
>
> I certainly disagree on the readability aspect. The switch means I have to look through each section to figure out what it does for each state. In contrast:
> 
> state = ...
> return state == _thread_in_Java || state == _thread_in_Java_trans;
> ``
> is IMO blindingly obvious.

But this doesn't check whether the state could be something new an unsupported.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1823830091


More information about the hotspot-dev mailing list