RFR: 8342818: Implement CPU Time Profiling for JFR [v4]

Johannes Bechberger jbechberger at openjdk.org
Thu Oct 31 13:21:38 UTC 2024


On Thu, 31 Oct 2024 02:59:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> The idea is to place it close to the other method sampler.
>
> Why? Large chunks of platform specific code should be in platform specific files. That is the way hotspot sources are arranged.

Can we postpone this change to a later stage? This would possibly invalidate lot's of GitHub comments. I see the point of the change, but I think there are currently more pressing things.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1824442236


More information about the hotspot-dev mailing list