RFR: 8339359: RISC-V: Use auipc explicitly in far_jump and far_call macro assembler routines
Robbin Ehn
rehn at openjdk.org
Mon Sep 2 09:56:17 UTC 2024
On Mon, 2 Sep 2024 01:15:36 GMT, Fei Yang <fyang at openjdk.org> wrote:
> Previous discussion: https://github.com/openjdk/jdk/pull/18942#issuecomment-2109162337
>
> For MacroAssembler::far_call and MacroAssembler::far_jump, I would suggest we use explicit
> auipc instead of MacroAssembler::la for them as the destination is ensured to be in code cache.
> This will help save unnecessary check in MacroAssembler::la and make the code more consistent.
> Also this will help distinguish these two macro assembler routines from MacroAssembler::rt_call
>
> Testing:
> - [x] release & fastdebug builds
> - [ ] Tiered 1-3 tests
Looks good, thanks!
A personal opionion is that I really like my assembler to be as WYSIWYG as possible.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20805#issuecomment-2324315199
More information about the hotspot-dev
mailing list