RFR: 8339359: RISC-V: Use auipc explicitly in far_jump and far_call macro assembler routines [v2]

Robbin Ehn rehn at openjdk.org
Tue Sep 3 05:44:19 UTC 2024


On Tue, 3 Sep 2024 02:14:05 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Previous discussion: https://github.com/openjdk/jdk/pull/18942#issuecomment-2109162337
>> 
>> For MacroAssembler::far_call and MacroAssembler::far_jump, I would suggest we use explicit
>> auipc instead of MacroAssembler::la for them as the destination is ensured to be in code cache.
>> This will help save unnecessary check in MacroAssembler::la and make the code more consistent.
>> Also this will help distinguish these two macro assembler routines from MacroAssembler::rt_call
>> 
>> Testing:
>> - [x] release & fastdebug builds
>> - [x] Tiered 1-3 tests
>
> Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Fix assertion message
>  - Merge remote-tracking branch 'upstream/master' into JDK-8339359
>  - 8339359: RISC-V: Use auipc explicitly in far_jump and far_call macro assembler routines

Thanks, yes!

-------------

Marked as reviewed by rehn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20805#pullrequestreview-2276446008


More information about the hotspot-dev mailing list