RFR: 8339466: Enumerate shared stubs and define static fields and names via declarations [v2]

[Vladimir Kozlov]

On Tue, 3 Sep 2024 10:51:53 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Systematize handling of SharedRuntime stubs. Generate enum ids, static fields and names from declarations using template macros. Systematically reference stubs and stub names using ids.
>
> Andrew Dinn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix errors in ppc generator

src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 2571:

> 2569: SafepointBlob* SharedRuntime::generate_handler_blob(sharedStubId id, address call_ptr) {
> 2570:   assert((id >= sharedStubId::polling_page_vectors_safepoint_handler_id ||
> 2571:           id <= sharedStubId::polling_page_return_handler_id),

This and all other similar assert checks depends on the order of stubs ID.
I think such checks should be in `sharedStubId` where the order is defined:
`sharedStubId::is_polling_page_id(id)`

src/hotspot/share/runtime/stubDeclarations.hpp line 2:

> 1: /*
> 2:  * Copyright (c) 2024, 2024, Oracle and/or its affiliates. All rights reserved.

You need only one 2024 year

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20832#discussion_r1742492107
PR Review Comment: https://git.openjdk.org/jdk/pull/20832#discussion_r1742486529