RFR: 8339316: Test runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java fails after JDK-8338257 [v2]

David Holmes dholmes at openjdk.org
Wed Sep 4 04:26:58 UTC 2024


> In JDK-8338257 I overlooked updating the callers of `UTF8::is_legal_utf8` to pass a `size_t` length parameter. In some cases the length was explicitly cast to `int` and in the test case in question (with `-Xcheck:jni`) this caused integer overflow to a negative value which then became an exceedingly large `size_t` value and we then tried to do utf8 validation on random bytes.
> 
> Testing:
> - failing test
> - tiers 1-4
> 
> Thanks

David Holmes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into 8339316-verify-utf8
 - 8339316: Test runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java fails after JDK-8338257

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20804/files
  - new: https://git.openjdk.org/jdk/pull/20804/files/920b4da3..4263a4c4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20804&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20804&range=00-01

  Stats: 4157 lines in 181 files changed: 2263 ins; 982 del; 912 mod
  Patch: https://git.openjdk.org/jdk/pull/20804.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20804/head:pull/20804

PR: https://git.openjdk.org/jdk/pull/20804


More information about the hotspot-dev mailing list