RFR: 8333446: Add tests for hierarchical container support [v9]

Severin Gehwolf sgehwolf at openjdk.org
Wed Sep 4 17:46:00 UTC 2024


> Please review this PR which adds test support for systemd slices so that bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be verified. The added test, `SystemdMemoryAwarenessTest` currently passes on cgroups v1 and fails on cgroups v2 due to the way how [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) was implemented when JDK 13 was a thing. Therefore immediately problem-listed. It should get unlisted once [JDK-8322420](https://bugs.openjdk.org/browse/JDK-8322420) merges.
> 
> I'm adding those tests in order to not regress another time.
> 
> Testing:
> - [x] Container tests on Linux x86_64 cgroups v2 and Linux x86_64 cgroups v1.
> - [x] New systemd test on cg v1 (passes). Fails on cg v2 (due to  JDK-8322420)
> - [x] GHA

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:

 - Adapt JDK-8339148
 - Merge branch 'master' into jdk-8333446-systemd-slice-tests
 - Merge branch 'master' into jdk-8333446-systemd-slice-tests
 - Fix comment of WB::host_cpus()
 - Handle non-root + CGv2
 - Add nested hierarchy to test framework
 - Revert "Add root check for SystemdMemoryAwarenessTest.java"
   
   This reverts commit 7e8d9ed46815096ae8c4502f3320ebf5208438d5.
 - Add root check for SystemdMemoryAwarenessTest.java
 - Merge branch 'master' into jdk-8333446-systemd-slice-tests
 - Merge branch 'master' into jdk-8333446-systemd-slice-tests
 - ... and 7 more: https://git.openjdk.org/jdk/compare/29f3dd39...30f32d22

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19530/files
  - new: https://git.openjdk.org/jdk/pull/19530/files/cf49a96e..30f32d22

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19530&range=08
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19530&range=07-08

  Stats: 2593 lines in 119 files changed: 1994 ins; 169 del; 430 mod
  Patch: https://git.openjdk.org/jdk/pull/19530.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19530/head:pull/19530

PR: https://git.openjdk.org/jdk/pull/19530


More information about the hotspot-dev mailing list