Integrated: 8339316: Test runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java fails after JDK-8338257

David Holmes dholmes at openjdk.org
Thu Sep 5 00:00:59 UTC 2024


On Mon, 2 Sep 2024 00:40:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

> In JDK-8338257 I overlooked updating the callers of `UTF8::is_legal_utf8` to pass a `size_t` length parameter. In some cases the length was explicitly cast to `int` and in the test case in question (with `-Xcheck:jni`) this caused integer overflow to a negative value which then became an exceedingly large `size_t` value and we then tried to do utf8 validation on random bytes.
> 
> Testing:
> - failing test
> - tiers 1-4
> 
> Thanks

This pull request has now been integrated.

Changeset: 96df5a6d
Author:    David Holmes <dholmes at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/96df5a6d8f90c988b354dbe6bdc510aa4b8ee98b
Stats:     11 lines in 7 files changed: 1 ins; 4 del; 6 mod

8339316: Test runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java fails after  JDK-8338257

Reviewed-by: jsjolen, coleenp

-------------

PR: https://git.openjdk.org/jdk/pull/20804


More information about the hotspot-dev mailing list