RFR: 8338471: Refactor Method::get_new_method() for better NoSuchMethodError handling

[Dean Long]

On Thu, 5 Sep 2024 18:56:19 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> This patch cleans up the use of `get_new_method()` so callers don't have to worry about throwing `NoSuchMethodError`. The method is refactored to throw the error and avoid ever returning nullptr. Verified with tier1-5 tests.

I recently added ciMethod::equals() in JDK-8335120, but I didn't take into account deleted methods.  Could you please fix ciMethod::equals() in this PR?  With your changes to get_new_method(), it looks like ciMethod::equals() will incorrectly think that two methods are the same if both are deleted.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20874#issuecomment-2332581305