RFR: 8338471: Refactor Method::get_new_method() for better NoSuchMethodError handling

[David Holmes]

On Thu, 5 Sep 2024 18:56:19 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> This patch cleans up the use of `get_new_method()` so callers don't have to worry about throwing `NoSuchMethodError`. The method is refactored to throw the error and avoid ever returning nullptr. Verified with tier1-5 tests.

Sorry I have to retract my review. It is not at all obvious that all the other uses of `get_new_method()` remain correct after this change.

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20874#pullrequestreview-2285027355