RFR: 8338471: Refactor Method::get_new_method() for better NoSuchMethodError handling [v2]

[Coleen Phillimore]

On Fri, 6 Sep 2024 19:51:18 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> This patch cleans up the use of `get_new_method()` so callers don't have to worry about throwing `NoSuchMethodError`. The method is refactored to throw the error and avoid ever returning nullptr. Verified with tier1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed conditional to check for is_deleted()

This looks good.  It's good to isolate the deleted method code.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20874#pullrequestreview-2287153463