RFR: 8338658: New Object to ObjectMonitor mapping: s390x implementation [v2]

Martin Doerr mdoerr at openjdk.org
Mon Sep 9 09:42:06 UTC 2024


On Mon, 2 Sep 2024 18:15:19 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> src/hotspot/cpu/s390/macroAssembler_s390.cpp line 6165:
> 
>> 6163:     z_stg(tmp1, Address(box, BasicLock::object_monitor_cache_offset_in_bytes()));
>> 6164:   }
>> 6165: 
> 
> Why not use mvghi here to directly write zero to memory? Prerequisites: displacement must be uimm12.

+1

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20740#discussion_r1749935121


More information about the hotspot-dev mailing list