RFR: 8334060: Implementation of Late Barrier Expansion for G1 [v17]

[Roberto Castañeda Lozano]

On Fri, 6 Sep 2024 23:57:59 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   s390 port : late barrier expansion
>
> src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp line 354:
> 
>> 352:   __ bind(runtime);
>> 353:   // save the live input values
>> 354:   RegSet saved = RegSet::of(store_addr NOT_LP64(COMMA thread));
> 
> I was looking at this a while ago, and haven't figured out why we're saving `store_addr` here.
> Also not sure why we're saving `thread` here for 32bit platforms.
> Something to think about for the future.  Though maybe the 32bit case will be gone by then :)

I'm not sure either, this is in any case pre-existing interpreter code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19746#discussion_r1750105760