RFR: 8337563: NMT: rename MEMFLAGS to MemTag
Coleen Phillimore
coleenp at openjdk.org
Mon Sep 9 13:39:07 UTC 2024
On Thu, 5 Sep 2024 16:10:05 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related parameter names and local variable names.
>
> Testing is pending...
>
> Note: there is more history in old closed PRs [https://github.com/openjdk/jdk/pull/20497](https://github.com/openjdk/jdk/pull/20497) and [https://github.com/openjdk/jdk/pull/20472](https://github.com/openjdk/jdk/pull/20472)
Some people wanted chunks and some people wanted it all at once. After fixing these instances that you've pointed out, Gerard can have another pass with things that might not be noticed on this pass.
The MemTag F pattern could be changed to MemTag MT (or left for a further review, which is my preference). The capital letter T seems like a bad choice for this.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20872#issuecomment-2338144129
More information about the hotspot-dev
mailing list