RFR: 8339738: RISC-V: Vectorize crc32 intrinsic [v2]

[Hamlin Li]

On Tue, 10 Sep 2024 15:15:02 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   zext_w
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 1469:
> 
>> 1467: 
>> 1468:     // prepare
>> 1469:     add(tableN16, table3, 1*256*sizeof(juint), tmp1);
> 
> where is that `1*256` coming from? It would be worth a comment

I copied it from the original code.

> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 1481:
> 
>> 1479:     }
>> 1480:     vmv_v_x(vcrc, zr);
>> 1481:     slli(crc, crc, 32);
> 
> You can use zero extend here.

Thanks, I'll fix it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20910#discussion_r1752200820
PR Review Comment: https://git.openjdk.org/jdk/pull/20910#discussion_r1752201230