RFR: 8339627: Cleanup Unsafe.setMemory intrinsic code
Thomas Schatzl
tschatzl at openjdk.org
Wed Sep 11 09:36:04 UTC 2024
On Thu, 5 Sep 2024 17:46:49 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
> Hi,
>
> The code for the `Unsafe.setMemory` intrinsic has a few issues that this PR cleans up.
>
> 1. The labels are unused in x86-64 intrinsic
> 2. The function stub has an incorrect function prototype as it clearly manipulates the array so the array is not const, and we don't read the array so it probably shouldn't be called `src`. That's probably just an issue of `UnsafeArrayCopyStub` being copied and altered insufficiently.
>
> Thanks.
lgtm.
-------------
Marked as reviewed by tschatzl (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20873#pullrequestreview-2296208213
More information about the hotspot-dev
mailing list