RFR: 8320318: ObjectMonitor Responsible thread

[Fredrik Bredberg]

On Wed, 11 Sep 2024 12:08:25 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/objectMonitor.cpp line 310:
>> 
>>> 308: 
>>> 309: bool ObjectMonitor::enterI_with_contention_mark(JavaThread* locking_thread, ObjectMonitorContentionMark& contention_mark) {
>>> 310:   // Used by ObjectSynchronizer::enter_for() to enter for another thread.
>> 
>> This renaming is confusing for me. The `enter_for` methods were made explicit because normally locking is always done by the current thread for the current thread - but deopt breaks that. And now it seems we have an `EnterI` that is really an `EnterI_for` ??
>
> Me too. So many functions that are sort of the same.

As I wrote above, the confusing renaming has to be fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19454#discussion_r1754518155