RFR: 8320318: ObjectMonitor Responsible thread
David Holmes
dholmes at openjdk.org
Thu Sep 12 00:03:05 UTC 2024
On Tue, 10 Sep 2024 07:56:25 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:
>> Removed the concept of an ObjectMonitor Responsible thread.
>>
>> The reason to have an ObjectMonitor Responsible thread was to avoid threads getting stranded due to a hole in the successor protocol. This hole was there because adding the necessary memory barrier was considered too expensive some 20 years ago.
>>
>> The ObjectMonitor Responsible thread code adds complexity, and doing timed parks just to avoid getting stranded is not the way forward. More info about the problems with the ObjectMonitor responsible thread can be found in [JDK-8320318](https://bugs.openjdk.org/browse/JDK-8320318).
>>
>> After removing the ObjectMonitor Responsible thread we see increased performance on all supported platforms except Windows. [JDK-8339730](https://bugs.openjdk.org/browse/JDK-8339730) has been created to handle this.
>>
>> Passes tier1-tier7 on supported platforms.
>> x64, AArch64, Riscv64, ppc64le and s390x passes ok on the test/micro/org/openjdk/bench/vm/lang/LockUnlock.java test.
>> Arm32 and Zero doesn't need any changes as far as I can tell.
>
> I've done basic testing on ppc64le, riscv64 and s390x using QEMU, but would appreciate if @TheRealMDoerr, @RealFYang and @offamitkumar could take it for a real test drive.
> @fbredber, @dholmes-ora: I got a substantial performance drop on our 96 Thread Xeon server:
What OS for the Xeon? We have only seen issues with Windows.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19454#issuecomment-2344995807
More information about the hotspot-dev
mailing list