RFR: 8320318: ObjectMonitor Responsible thread [v2]

[Fredrik Bredberg]

On Tue, 10 Sep 2024 14:39:37 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update one, after the review
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 237:
> 
>> 235:   ld(t0, Address(tmp, ObjectMonitor::EntryList_offset()));
>> 236:   ld(disp_hdr, Address(tmp, ObjectMonitor::cxq_offset()));
>> 237:   orr(t0, t0, disp_hdr);
> 
> It looks better to me if we use `tmp1Reg` here instead of its alias `disp_hdr` like you do for aarch64. I mean:
> 
> ld(tmp1Reg, Address(tmp, ObjectMonitor::cxq_offset()));
> orr(t0, t0, tmp1Reg);

fixed

> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 568:
> 
>> 566:     ld(tmp3_t, Address(tmp1_monitor, ObjectMonitor::cxq_offset()));
>> 567:     orr(t0, t0, tmp3_t);
>> 568:     beqz(t0, unlocked); // If so we are done.
> 
> You might want to remove the preceding definition of label `release` as it is not used after this change.

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19454#discussion_r1758852591
PR Review Comment: https://git.openjdk.org/jdk/pull/19454#discussion_r1758852979