RFR: 8339416: [s390x] Provide implementation for resolve_global_jobject [v2]

Amit Kumar amitkumar at openjdk.org
Mon Sep 16 04:56:36 UTC 2024


On Mon, 16 Sep 2024 04:53:11 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> This PR provides "resolve_global_jobject" method implementation for s390x-port. 
>> 
>> Testing:
>> * Tier1 test with Fastdebug; 
>> * Added these changes on top of https://github.com/openjdk/jdk/pull/20479 and modified the call in the stubGenerator_s390.cpp file; 
>> *  1. Ran tier1 test with a call to  "resolve_jobect"
>> *  2. Ran tier1 test with a call to  "resolve_global_jobject" 
>> 
>> I didn't see any new failure appearing there.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removes extra line

src/hotspot/cpu/s390/macroAssembler_s390.cpp line 3681:

> 3679:   bs->resolve_global_jobject(this, value, tmp1, tmp2);
> 3680: }
> 3681: 

Suggestion:

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20986#discussion_r1760529772


More information about the hotspot-dev mailing list