Integrated: 8339627: Cleanup Unsafe.setMemory intrinsic code

Johan Sjölen jsjolen at openjdk.org
Mon Sep 16 09:16:14 UTC 2024


On Thu, 5 Sep 2024 17:46:49 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi,
> 
> The code for the `Unsafe.setMemory` intrinsic has a few issues that this PR cleans up.
> 
> 1. The labels are unused in x86-64 intrinsic
> 2. The function stub has an incorrect function prototype as it clearly manipulates the array so the array is not const, and we don't read the array so it probably shouldn't be called `src`. That's probably just an issue of `UnsafeArrayCopyStub` being copied and altered insufficiently.
> 
> Thanks.

This pull request has now been integrated.

Changeset: 54595188
Author:    Johan Sjölen <jsjolen at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/545951889c1ea68646be600decaf2bf4c049600b
Stats:     4 lines in 2 files changed: 0 ins; 3 del; 1 mod

8339627: Cleanup Unsafe.setMemory intrinsic code

Reviewed-by: tschatzl, fbredberg

-------------

PR: https://git.openjdk.org/jdk/pull/20873


More information about the hotspot-dev mailing list