RFR: 8340184: Bug in CompressedKlassPointers::is_in_encodable_range [v2]

[Thomas Stuefe]

On Mon, 16 Sep 2024 14:23:16 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - comment fix
>>  - comment fix missing close paranthesys
>>  - Feedback Johan
>>  - Feedback Coleen
>
> src/hotspot/cpu/aarch64/compressedKlass_aarch64.cpp line 134:
> 
>> 132:   // Remember the Klass range:
>> 133:   _klass_range_start = addr;
>> 134:   _klass_range_end = addr + len;
> 
> In the Lilliput review, I think you were moving this to shared code with an ifdef so that these variables are all set in one place.  This is ok here for now.

Yes I did this. I like the Lilliput variant better too.

> test/hotspot/jtreg/gtest/CompressedKlassGtest.java line 31:
> 
>> 29:  * mode, we start with CDS disabled, a small class space and a large (albeit uncommitted, to save memory) heap. The
>> 30:  * JVM will likely place the class space in low-address territory.
>> 31:  * (If it does not manage to do this, the test will note that and print "skipped"
> 
> Ok, I see why you have this.  thanks for the comment.  One nit, the ) is missing in this sentence.

Fixed :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21015#discussion_r1761267520
PR Review Comment: https://git.openjdk.org/jdk/pull/21015#discussion_r1761273994