RFR: 8340184: Bug in CompressedKlassPointers::is_in_encodable_range [v2]

[Thomas Stuefe]

On Mon, 16 Sep 2024 13:49:50 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - comment fix
>>  - comment fix missing close paranthesys
>>  - Feedback Johan
>>  - Feedback Coleen
>
> src/hotspot/share/oops/compressedKlass.hpp line 117:
> 
>> 115: 
>> 116:   // Start and end of the Klass Range.
>> 117:   // Note: guaranteed to be aligned to 1<<shift (klass_alignment_in_bytes)
> 
>>1<<shift (klass_alignment_in_bytes)
> 
> This is confusing to me, you mean `1 << klass_alignment_in_bytes`, right?

No, its correct. "1 << shift" is klass alignment, in bytes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21015#discussion_r1761263668