RFR: 8339790: Support Intel APX setzucc instruction [v4]

Sandhya Viswanathan sviswanathan at openjdk.org
Mon Sep 16 23:02:12 UTC 2024


On Mon, 16 Sep 2024 21:05:01 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 10426:
>> 
>>> 10424: 
>>> 10425: void MacroAssembler::setcc(Assembler::Condition comparison, Register dst) {
>>> 10426:   if (VM_Version::supports_apx_f()) {
>> 
>> We could check UseAPX here instead of VM_Version::supports_apx_f().
>
> I think switching off a feature in `vm_version` file based on flags setting is correct.
> So that in the rest of code we can simple check `VM_Version::supports_*()`.
> Currently not all code follow this but it is preferable way.

Sounds good, let us keep it this way (VM_Version::supports_*()).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20920#discussion_r1762059128


More information about the hotspot-dev mailing list