RFR: 8339416: [s390x] Provide implementation for resolve_global_jobject [v3]
Martin Doerr
mdoerr at openjdk.org
Tue Sep 17 11:01:40 UTC 2024
On Tue, 17 Sep 2024 10:58:23 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
>> This PR provides "resolve_global_jobject" method implementation for s390x-port.
>>
>> Testing:
>> * Tier1 test with Fastdebug;
>> * Added these changes on top of https://github.com/openjdk/jdk/pull/20479 and modified the call in the stubGenerator_s390.cpp file;
>> * 1. Ran tier1 test with a call to "resolve_jobect"
>> * 2. Ran tier1 test with a call to "resolve_global_jobject"
>>
>> I didn't see any new failure appearing there.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> implements ModRefBarrierSetAssembler::resolve_jobject
LGTM. Note that the generic implementation of `resolve_jobject` is now unused, but will be used if ZGC or Shenandoah get implemented.
-------------
Marked as reviewed by mdoerr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20986#pullrequestreview-2309110989
More information about the hotspot-dev
mailing list