RFR: 8339416: [s390x] Provide implementation for resolve_global_jobject [v2]

Amit Kumar amitkumar at openjdk.org
Tue Sep 17 11:01:41 UTC 2024


On Mon, 16 Sep 2024 16:41:27 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removes extra line
>
> src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp line 108:
> 
>> 106: }
>> 107: 
>> 108: // Generic implementation. GCs can provide an optimized one.
> 
> You may want to implement an optimized `G1BarrierSetAssembler::resolve_jobject` and `ModRefBarrierSetAssembler::resolve_jobject`. Otherwise, those GCs may get a regression.

I have added implementation for `ModRefBarrierSetAssembler::resolve_jobject`. It seems `G1BarrierSetAssembler::resolve_jobject` is already present, do I need to do anything extra than that ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20986#discussion_r1762686675


More information about the hotspot-dev mailing list