RFR: 8322770: Implement C2 VectorizedHashCode on AArch64 [v7]
Mikhail Ablakatov
duke at openjdk.org
Tue Sep 17 16:24:30 UTC 2024
On Tue, 17 Sep 2024 15:47:08 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> Mikhail Ablakatov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> cleanup: fix comment formatting
>>
>> Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com>
>
> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 103:
>
>> 101: // offsets past |(r - lc) % uf| pairs of load + madd insns i.e. it only executes
>> 102: // r % uf load + madds. Iteration eats up the remainder, uf elements at a time.
>> 103: assert(is_power_of_2(unroll_factor), "can't use this value to calculate the jump target PC");
>
> The comment above needs adjusting in the light of your latest change.
Done, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18487#discussion_r1763533579
More information about the hotspot-dev
mailing list