RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v11]
Simon Tooke
stooke at openjdk.org
Wed Sep 18 10:24:08 UTC 2024
On Wed, 18 Sep 2024 10:18:28 GMT, Simon Tooke <stooke at openjdk.org> wrote:
>> This PR changes the status of realpath() from a Posix-specific API to a globally available API, i.e. adding it to the "Hotspot Porting API". Code would refer to os::realpath() instead of os::Posix::realpath().
>>
>> This requires a Windows implementation of realpath(), using Windows _fullpath(), and renaming os::Posix::realpath() to os::realpath().
>>
>> The main difference between POSIX and Windows behaviour is that POSIX actually requires an existing accessible file, while Windows will happily work with made-up filenames.
>>
>> Please note that guidelines for doing this appear in src/hotspot/share/runtime/os.hpp
>
> Simon Tooke has updated the pull request incrementally with one additional commit since the last revision:
>
> remove tabs
I have added a gtest for some of the common error cases using realpath().
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20683#issuecomment-2358087840
More information about the hotspot-dev
mailing list