RFR: 8320318: ObjectMonitor Responsible thread [v3]

Fredrik Bredberg fbredberg at openjdk.org
Wed Sep 18 18:29:23 UTC 2024


> Removed the concept of an ObjectMonitor Responsible thread.
> 
> The reason to have an ObjectMonitor Responsible thread was to avoid threads getting stranded due to a hole in the successor protocol. This hole was there because adding the necessary memory barrier was considered too expensive some 20 years ago.
> 
> The ObjectMonitor Responsible thread code adds complexity, and doing timed parks just to avoid getting stranded is not the way forward. More info about the problems with the ObjectMonitor responsible thread can be found in [JDK-8320318](https://bugs.openjdk.org/browse/JDK-8320318).
> 
> After removing the ObjectMonitor Responsible thread we see increased performance on all supported platforms except Windows. [JDK-8339730](https://bugs.openjdk.org/browse/JDK-8339730) has been created to handle this.
> 
> Passes tier1-tier7 on supported platforms.
> x64, AArch64, Riscv64, ppc64le and s390x passes ok on the test/micro/org/openjdk/bench/vm/lang/LockUnlock.java test.
> Arm32 and Zero doesn't need any changes as far as I can tell.

Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:

  Update two, after the review

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19454/files
  - new: https://git.openjdk.org/jdk/pull/19454/files/d2c6db2b..ef5d1683

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19454&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19454&range=01-02

  Stats: 102 lines in 9 files changed: 30 ins; 45 del; 27 mod
  Patch: https://git.openjdk.org/jdk/pull/19454.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19454/head:pull/19454

PR: https://git.openjdk.org/jdk/pull/19454


More information about the hotspot-dev mailing list