RFR: 8293187: Store initialized Enum classes in AOTCache [v8]

Ioi Lam iklam at openjdk.org
Thu Sep 19 02:41:19 UTC 2024


On Wed, 18 Sep 2024 15:54:00 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>> 
>>  - erge branch 'jep-483-step-03-8329706-implement-xx-aot-class-linking' of /jdk3/yak/open into jep-483-step-04-8293187-support-sun-invoke-util-wrapper-in-cds-archive-heap
>>  - fixed merge
>>  - Merge branch 'jep-483-step-03-8329706-implement-xx-aot-class-linking' of /jdk3/yak/open into jep-483-step-04-8293187-support-sun-invoke-util-wrapper-in-cds-archive-heap
>>  - @ashu-mehra comment: assert that ConstantDescs, etc, must be initialized
>>  - Improved in-line comments
>>  - Merge branch 'jep-483-step-03-8329706-implement-xx-aot-class-linking' of /jdk3/yak/open into jep-483-step-04-8293187-support-sun-invoke-util-wrapper-in-cds-archive-heap
>>  - @vnkozlov comments
>>  - Clean up; removed unrelated changes in classPrinter.cpp
>>  - more cleanup
>>  - Merge branch 'jep-483-step-03-8329706-implement-xx-aot-class-linking' of /jdk3/yak/open into jep-483-step-04-8293187-support-sun-invoke-util-wrapper-in-cds-archive-heap
>>  - ... and 6 more: https://git.openjdk.org/jdk/compare/be1d0ef1...0970a0e2
>
> src/hotspot/share/cds/aotClassInitializer.cpp line 50:
> 
>> 48:     // - If we re-run the <clinit> of these 3 classes again during the production
>> 49:     //   run, ConstantDescs.CD_Boolean will get a new value that has a different
>> 50:     //   object identity than the value referenced the the Wrapper enums.
> 
> typo: than the value referenced _the_ the Wrapper enums  ->  than the value referenced _by_ the Wrapper enums.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20958#discussion_r1766066855


More information about the hotspot-dev mailing list