RFR: 8340392: Handle OopStorage in location decoder [v4]

Aleksey Shipilev shade at openjdk.org
Thu Sep 19 08:25:19 UTC 2024


On Thu, 19 Sep 2024 06:03:14 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Try to handle unaligned pointers well
>>  - Indenting and formats
>
> src/hotspot/share/gc/shared/oopStorage.cpp line 1140:
> 
>> 1138: bool OopStorage::print_containing(const oop* addr, outputStream* st) {
>> 1139:   if (addr != nullptr) {
>> 1140:     Block *block = find_block_or_null(addr);
> 
> Suggestion:
> 
>     Block* block = find_block_or_null(addr);

Thanks, fixed in new commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21072#discussion_r1766382633


More information about the hotspot-dev mailing list