RFR: 8340439: AArch64: Extra entry declaration for assember test

Leonid Mesnik lmesnik at openjdk.org
Fri Sep 20 02:56:37 UTC 2024


On Thu, 19 Sep 2024 11:54:32 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> The function declaration `extern "C" void entry(CodeBuffer*);` in `src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp` line 74, seems to used for AArch64 assember test.
> The AArch64 assember test has been moved to `test/hotspot/gtest` by [JDK-8252684](https://bugs.openjdk.org/browse/JDK-8252684) , so I think this function declaration can be remove.
> 
> Additional testing:
> 
> - [x] linux aarch64 jtreg(tier1/2/3 etc., include gtest) with release build
> - [x] linux aarch64 jtreg(tier1/2/3 etc., include gtest) with fastdebug build

Marked as reviewed by lmesnik (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21086#pullrequestreview-2317121604


More information about the hotspot-dev mailing list