RFR: 8322770: Implement C2 VectorizedHashCode on AArch64 [v9]
Andrew Haley
aph at openjdk.org
Fri Sep 20 09:36:45 UTC 2024
On Thu, 19 Sep 2024 15:01:48 GMT, Mikhail Ablakatov <duke at openjdk.org> wrote:
>> Could you point me towards asm tests for *Vector - Scalar* insts like `fmlavs`, `fmlsvs` or `fmulxvs` ([assembler_aarch64.hpp#L2857](https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/assembler_aarch64.hpp:2857))? Judging by git blame these were added without any new tests. Am I right assuming we are missing asm tests for *Vector - Scalar* instructions in general?
>
> It was renamed to `mulvs` by https://github.com/openjdk/jdk/pull/18487/commits/419f39473b53099b7bd42c33380a6ccb3917ab16
It's certainly possible that we are missing them. There was a period when `Assembler` changes were't being fully tested, but I've reviewed PRs more strictly since I realized.
In this case, though, there is a bug which will be revealed by testing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18487#discussion_r1768295246
More information about the hotspot-dev
mailing list