RFR: 8318127: align_up has potential overflow

Andrew Haley aph at openjdk.org
Sun Sep 22 08:48:34 UTC 2024


On Sat, 21 Sep 2024 00:20:23 GMT, Dean Long <dlong at openjdk.org> wrote:

> Maybe we need two versions of this function, one that allows wrap-around and the other that doesn't. I'm guessing that for most callers, wrap-around would be unexpected and cause bugs, so let's have them ask for it explicitly.

Sounds good to me, but we'd have to be careful about existing usages. I'd just make it so that overflow was signalled for signed types, but perhaps explicit checked and unchecked function names are clearer to the reader,

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20808#issuecomment-2366119016


More information about the hotspot-dev mailing list