RFR: 8327652: S390x: Implements SLP support [v9]

Amit Kumar amitkumar at openjdk.org
Mon Sep 23 04:50:43 UTC 2024


On Mon, 23 Sep 2024 04:41:07 GMT, Sidraya Jayagond <sjayagond at openjdk.org> wrote:

>> src/hotspot/cpu/s390/vmreg_s390.cpp line 48:
>> 
>>> 46: 
>>> 47:   VectorRegister vreg = ::as_VectorRegister(0);
>>> 48:   for (; i < ConcreteRegisterImpl::max_vr;) {
>> 
>> NIT: this really looks like a `while` loop.
>
> @JohnTortugo Could you elaborate more on this?

I think this is what he meant: 
Suggestion:

  while(i < ConcreteRegisterImpl::max_vr) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18162#discussion_r1770767832


More information about the hotspot-dev mailing list