RFR: 8322770: Implement C2 VectorizedHashCode on AArch64 [v9]

Andrew Haley aph at openjdk.org
Mon Sep 23 11:00:46 UTC 2024


On Mon, 23 Sep 2024 09:37:17 GMT, Mikhail Ablakatov <duke at openjdk.org> wrote:

>> It's certainly possible that we are missing them. There was a period when `Assembler` changes were't being fully tested, but I've reviewed PRs more strictly since I realized.
>> In this case, though, there is a bug which will be revealed by testing.
>
> Fixed and tested by https://github.com/openjdk/jdk/pull/18487/commits/3d7af279cd33b842ea332404005bbb54e2cd1d0b and https://github.com/openjdk/jdk/pull/18487/commits/132baf86e4c2418ba4e9f337612f6a38e37da777 accordingly, please check.

> Fixed and tested by [3d7af27](https://github.com/openjdk/jdk/commit/3d7af279cd33b842ea332404005bbb54e2cd1d0b) and [132baf8](https://github.com/openjdk/jdk/commit/132baf86e4c2418ba4e9f337612f6a38e37da777) accordingly, please check.

See my minor style suggestion, but otherwise this looks fine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18487#discussion_r1771196781


More information about the hotspot-dev mailing list