RFR: 8340422: ZGC: TestAllocateHeapAt.java should not run with transparent hugepages [v2]
Stefan Karlsson
stefank at openjdk.org
Tue Sep 24 07:17:37 UTC 2024
On Tue, 24 Sep 2024 05:51:06 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
>> Similarly to [JDK-8340146](https://bugs.openjdk.org/browse/JDK-8340146) / #21127 does not work well with transparent hugepages.
>>
>> Because a machine may be configured in such a way that UseTransperetHugePages option gets ignored, the test driver must also check if it will be. As such I extracted the `test/hotspot/jtreg/runtime/os/HugePageConfiguration.java` utility into shared test library.
>>
>> On none linux machines the `vm.opt.final.UseTransparentHugePages` will be null, but the test checks `os.family == "linux"` first. I have not observed an issue with the JTREG filter on none linux machines. But will double check that it does not cause an issue.
>
> Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>
> - Merge remote-tracking branch 'upstream_jdk/master' into JDK-8340422
> - 8340422: ZGC: TestAllocateHeapAt.java should not run with transparent hugepages
Marked as reviewed by stefank (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/21129#pullrequestreview-2324287949
More information about the hotspot-dev
mailing list