RFR: 8340732: RISC-V: Refactor crc32 scalar version [v2]
Fei Yang
fyang at openjdk.org
Wed Sep 25 08:54:36 UTC 2024
On Wed, 25 Sep 2024 08:35:05 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Hi,
>> Can you help to review this patch?
>> As discussed in https://github.com/openjdk/jdk/pull/20910#discussion_r1755150447, it's helpful to refactor the existing scalar version of crc32 intrinsic.
>> Several refactoring are done in this pr,
>> 1. Simplify the `len` usage, now it only decreases (i.e. change in one direction)
>> 2. Simplify the code paths
>> 3. Remove one instruction in `L_by4_loop`
>> 4. Remove unnecessary code
>> 5. Other misc
>>
>> Thanks!
>
> Hamlin Li has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>
> - merge master
> - bltz -> beqz
> - Initial commit
Updated change looks good to me. Any test performed? Thanks.
-------------
Marked as reviewed by fyang (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21150#pullrequestreview-2327611766
More information about the hotspot-dev
mailing list