RFR: 8340843: [PPC64/s390x] Error: ShouldNotReachHere() in TemplateInterpreterGenerator::generate_math_entry after 8338694

[Martin Doerr]

On Wed, 25 Sep 2024 06:16:04 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> [JDK-8338694](https://bugs.openjdk.org/browse/JDK-8338694) introduced `Interpreter::java_lang_math_tanh` which needs to be handled by the interpreter. Unfortunately, `SharedRuntime::dtanh` does not exist, so we need to fallback to the normal interpreter entry (as before JDK-8338694).
>
> @TheRealMDoerr can you include change for s390x as well, please: 
> 
> diff --git a/src/hotspot/cpu/s390/templateInterpreterGenerator_s390.cpp b/src/hotspot/cpu/s390/templateInterpreterGenerator_s390.cpp
> index c16e4449045..0f35393a460 100644
> --- a/src/hotspot/cpu/s390/templateInterpreterGenerator_s390.cpp
> +++ b/src/hotspot/cpu/s390/templateInterpreterGenerator_s390.cpp
> @@ -1224,6 +1224,7 @@ address TemplateInterpreterGenerator::generate_math_entry(AbstractInterpreter::M
>      case Interpreter::java_lang_math_sin  : runtime_entry = CAST_FROM_FN_PTR(address, SharedRuntime::dsin);   break;
>      case Interpreter::java_lang_math_cos  : runtime_entry = CAST_FROM_FN_PTR(address, SharedRuntime::dcos);   break;
>      case Interpreter::java_lang_math_tan  : runtime_entry = CAST_FROM_FN_PTR(address, SharedRuntime::dtan);   break;
> +    case Interpreter::java_lang_math_tanh : /* run interpreted */ break;
>      case Interpreter::java_lang_math_abs  : /* run interpreted */ break;
>      case Interpreter::java_lang_math_sqrt : /* runtime_entry = CAST_FROM_FN_PTR(address, SharedRuntime::dsqrt); not available */ break;
>      case Interpreter::java_lang_math_log  : runtime_entry = CAST_FROM_FN_PTR(address, SharedRuntime::dlog);   break;

@offamitkumar: Please review!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21168#issuecomment-2373499340