RFR: 8340843: [PPC64/s390x] Error: ShouldNotReachHere() in TemplateInterpreterGenerator::generate_math_entry after 8338694 [v2]

Amit Kumar amitkumar at openjdk.org
Wed Sep 25 09:19:34 UTC 2024


On Wed, 25 Sep 2024 09:11:11 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> [JDK-8338694](https://bugs.openjdk.org/browse/JDK-8338694) introduced `Interpreter::java_lang_math_tanh` which needs to be handled by the interpreter. Unfortunately, `SharedRuntime::dtanh` does not exist, so we need to fallback to the normal interpreter entry (as before JDK-8338694).
>
> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add s390 fix.

Thank you  for adding the s390x changes :-)

-------------

Marked as reviewed by amitkumar (Committer).

PR Review: https://git.openjdk.org/jdk/pull/21168#pullrequestreview-2327672083


More information about the hotspot-dev mailing list