RFR: 8320318: ObjectMonitor Responsible thread [v3]

[Fredrik Bredberg]

On Fri, 20 Sep 2024 04:55:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update two, after the review
>
> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 535:
> 
>> 533: 
>> 534:     // Set owner to null.
>> 535:     // Release to satisfy the JMM
> 
> Can I suggest you use this comment form in each of the cpu-specific files. At the moment code that does the same thing is commented slightly differently with regard to the need for a release-store. Thanks.

fixed

> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 499:
> 
>> 497: #endif
>> 498: 
>> 499:   // Intentional fall-through into slow path
> 
> I don't think this comment makes sense / applies any more.

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19454#discussion_r1775314987
PR Review Comment: https://git.openjdk.org/jdk/pull/19454#discussion_r1775315614