RFR: 8322770: Implement C2 VectorizedHashCode on AArch64 [v14]
Mikhail Ablakatov
duke at openjdk.org
Wed Sep 25 16:11:20 UTC 2024
On Wed, 25 Sep 2024 10:54:26 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> The reason was to make the implementation handle all possible values of `load_arrangement` should it change. And it did while I was tuning the performance of the algorithm. The code is valid and I'd argue there's no mistake if we leave this line here. But I'm comfortable with removing it in order to make the current implementation less error-prone.
>
> Please remove it then as it can only serve to confuse maintainers. The code should visibly display consistent assumptions wherever possible.
Fixed by https://github.com/openjdk/jdk/pull/18487/commits/e2d1f711a093826c618242b291dc90195c027872.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18487#discussion_r1775515452
More information about the hotspot-dev
mailing list