RFR: 8320318: ObjectMonitor Responsible thread [v4]
Coleen Phillimore
coleenp at openjdk.org
Wed Sep 25 19:53:40 UTC 2024
On Wed, 25 Sep 2024 19:43:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Someone did want this comment in each of the cpu-specific files. I do like to use the same comment in all equal places, so I did what someone wanted. But having said that, CPUs are different. In some you need an explicit release-instruction (like a `membar` of some sort), and in others you don't. I do agree that in a cpu-specific file where it's not needed with an explicit release-instruction, this comment makes no (or less sense). What to do?
>
> Whoever asked for it, let's see if this is what they wanted. I thought the fence() comment below it is what was requested. I agree the comment should be repeated on all platforms though for consistency.
I see where it came from in the aarch64 code, and that code does a stlr() to satisfy the JMM. It's fine. Leave it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19454#discussion_r1775913934
More information about the hotspot-dev
mailing list