RFR: 8340576: Some JVMCI flags are inconsistent

Todd V. Jonker duke at openjdk.org
Wed Sep 25 21:41:37 UTC 2024


On Tue, 24 Sep 2024 22:09:42 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Studying these recent changes led me back to #14851 which added jtreg propeties:
>> 
>> - `jdk.hasLibgraal`: the libgraal shared library file is present
>> - `vm.libgraal.enabled`: libgraal is used as JIT compiler
>> 
>> The latter now feels misleading, since libgraal can be "enabled" for use by non-CompilerBroker compilations, without being used as the JIT compiler.  (I'm here b/c we're assembling a distro doing exactly that.)
>> 
>> Would it make sense to rename the latter, to reduce ambiguity in the tests?
>
>> Would it make sense to rename the latter, to reduce ambiguity in the tests?
> 
> Sounds reasonable to me. Maybe `vm.libgraal.jit`? The good news is that there are no current tests using this predicate as far as I can see.
> 
> Want to take the lead on this?

@dougxc I cut an issue https://bugs.openjdk.org/projects/JDK/issues/JDK-8340974 and posted a PR https://github.com/openjdk/jdk/pull/21190

This is my first JDK issue and fix; apologies if I'm getting the process wrong. I wasn't sure if I should tag you on either (or how).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21120#issuecomment-2375311109


More information about the hotspot-dev mailing list