RFR: 8339220: [s390x] TestIfMinMax.java failure

[Andrew Haley]

On Thu, 26 Sep 2024 06:08:40 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

> This test enables Conditional moves for long operands for s390x. Which fixes the test-case.
> 
> Ran tier1 and not saw any regression.

Looks good.
I wonder why it wasn't enabled already.

src/hotspot/cpu/s390/matcher_s390.hpp line 71:

> 69:       return 0;
> 70:     } else {
> 71:       return ConditionalMoveLimit;

Suggestion:

  // Use conditional move (CMOVL)
  static int long_cmove_cost() {
     // z196/z11 and later hardware supports conditional moves
     return VM_Version::get_model_index() >= 5 ? 0 : ConditionalMoveLimit: 
  }
 ```

-------------

Marked as reviewed by aph (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21198#pullrequestreview-2330581370
PR Review Comment: https://git.openjdk.org/jdk/pull/21198#discussion_r1776665999