RFR: 8339220: [s390x] TestIfMinMax.java failure [v2]

[Amit Kumar]

On Thu, 26 Sep 2024 10:06:08 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> This test enables Conditional moves for long operands for s390x. Which fixes the test-case.
>> 
>> Ran tier1 and not saw any regression.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   suggestions from Andrew

I did two benchmark, and I see some performance improvement, in `IfMinMax.testSingleLong` and  `IfMinMax.testVectorLong`:


Without Patch: 

Benchmark                   Mode  Cnt      Score      Error  Units
IfMinMax.testReductionInt   avgt   15   2073.648 ±    4.173  ns/op
IfMinMax.testReductionLong  avgt   15   2028.487 ±    1.246  ns/op
IfMinMax.testSingleInt      avgt   15      9.752 ±    0.172  ns/op
IfMinMax.testSingleLong     avgt   15     16.168 ±    0.248  ns/op
IfMinMax.testVectorInt      avgt   15   4713.057 ±   14.566  ns/op
IfMinMax.testVectorLong     avgt   15  27669.122 ± 4096.469  ns/op
Finished running test 'micro:vm.compiler.IfMinMax'


Benchmark                   Mode  Cnt      Score      Error  Units
IfMinMax.testReductionInt   avgt   15   2073.340 ±    4.624  ns/op
IfMinMax.testReductionLong  avgt   15   2028.775 ±    1.874  ns/op
IfMinMax.testSingleInt      avgt   15      9.742 ±    0.172  ns/op
IfMinMax.testSingleLong     avgt   15     16.286 ±    0.177  ns/op
IfMinMax.testVectorInt      avgt   15   4720.292 ±   30.984  ns/op
IfMinMax.testVectorLong     avgt   15  25043.432 ± 1627.543  ns/op
Finished running test 'micro:vm.compiler.IfMinMax'

===================================================================

With Patch: 

Benchmark                   Mode  Cnt     Score    Error  Units
IfMinMax.testReductionInt   avgt   15  2082.858 ± 27.064  ns/op
IfMinMax.testReductionLong  avgt   15  2029.843 ±  4.514  ns/op
IfMinMax.testSingleInt      avgt   15     9.743 ±  0.170  ns/op
IfMinMax.testSingleLong     avgt   15    10.072 ±  0.123  ns/op
IfMinMax.testVectorInt      avgt   15  4775.680 ±  9.953  ns/op
IfMinMax.testVectorLong     avgt   15  4736.881 ± 20.507  ns/op
Finished running test 'micro:vm.compiler.IfMinMax'

Benchmark                   Mode  Cnt     Score    Error  Units
IfMinMax.testReductionInt   avgt   15  2071.544 ±  2.536  ns/op
IfMinMax.testReductionLong  avgt   15  2030.751 ±  3.733  ns/op
IfMinMax.testSingleInt      avgt   15     9.630 ±  0.010  ns/op
IfMinMax.testSingleLong     avgt   15     9.921 ±  0.001  ns/op
IfMinMax.testVectorInt      avgt   15  4774.041 ±  2.562  ns/op
IfMinMax.testVectorLong     avgt   15  4753.247 ± 22.158  ns/op
Finished running test 'micro:vm.compiler.IfMinMax'

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21198#issuecomment-2376640053