RFR: 8320318: ObjectMonitor Responsible thread [v4]
David Holmes
dholmes at openjdk.org
Fri Sep 27 06:23:43 UTC 2024
On Fri, 27 Sep 2024 05:55:35 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Fredrik Bredberg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
>>
>> - Update three, after the review
>> - Merge branch 'master' into 8320318_objectmon_responsible_thread
>> - Update two, after the review
>> - Update one, after the review
>> - Small fixes before the review
>> - Merge branch 'master' into 8320318_objectmon_responsible_thread
>> - Merge branch 'master' into 8320318_objectmon_responsible_thread
>> - Removed _Responsible
>> - Fixed s390
>> - Fixed legacy locking
>> - ... and 4 more: https://git.openjdk.org/jdk/compare/0f253d11...8140570f
>
> src/hotspot/share/runtime/objectMonitor.cpp line 312:
>
>> 310: // The monitor is private to or already owned by locking_thread which must be suspended.
>> 311: // So this code may only contend with deflation.
>> 312: assert(locking_thread == Thread::current() || locking_thread->is_obj_deopt_suspend(), "must be");
>
> These comments and asserts seem to belong to `enter_for_with_contention_mark`. ??
And for `enter_for`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19454#discussion_r1778066968
More information about the hotspot-dev
mailing list