RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v8]
Hamlin Li
mli at openjdk.org
Fri Sep 27 09:28:36 UTC 2024
On Fri, 27 Sep 2024 08:10:35 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> `NDEBUG` is only used in sleefdp.c which is the original sleef code, and we don't use that file in jdk directly, in java.base module of jdk it uses `DEBUG` but not use `NDEBUG`.
>> Based on above information, I think `DEBUG` is better.
>
> Sounds good. I suppose this `DEBUG` macro will be defined for debug builds, right?
Yes, I tested on both release and fastdebug version.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21083#discussion_r1778316701
More information about the hotspot-dev
mailing list