RFR: 8320318: ObjectMonitor Responsible thread [v5]
Martin Doerr
mdoerr at openjdk.org
Fri Sep 27 10:01:43 UTC 2024
On Fri, 27 Sep 2024 07:42:15 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:
>> Removed the concept of an ObjectMonitor Responsible thread.
>>
>> The reason to have an ObjectMonitor Responsible thread was to avoid threads getting stranded due to a hole in the successor protocol. This hole was there because adding the necessary memory barrier was considered too expensive some 20 years ago.
>>
>> The ObjectMonitor Responsible thread code adds complexity, and doing timed parks just to avoid getting stranded is not the way forward. More info about the problems with the ObjectMonitor responsible thread can be found in [JDK-8320318](https://bugs.openjdk.org/browse/JDK-8320318).
>>
>> After removing the ObjectMonitor Responsible thread we see increased performance on all supported platforms except Windows. [JDK-8339730](https://bugs.openjdk.org/browse/JDK-8339730) has been created to handle this.
>>
>> Passes tier1-tier7 on supported platforms.
>> x64, AArch64, Riscv64, ppc64le and s390x passes ok on the test/micro/org/openjdk/bench/vm/lang/LockUnlock.java test.
>> Arm32 and Zero doesn't need any changes as far as I can tell.
>
> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>
> Update four, after the review
Test results on PPC64 look good. Is it already documented somewhere that `LockUnlock.testContendedLock` is getting slower with this change? I couldn't see it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19454#issuecomment-2378906937
More information about the hotspot-dev
mailing list