RFR: 8341101: [ARM32] Error: ShouldNotReachHere() in TemplateInterpreterGenerator::generate_math_entry after 8338694
Aleksey Shipilev
shade at openjdk.org
Fri Sep 27 18:24:38 UTC 2024
On Fri, 27 Sep 2024 17:17:09 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:
> [JDK-8338694](https://bugs.openjdk.org/browse/JDK-8338694) introduced Interpreter::java_lang_math_tanh which needs to be handled by the interpreter. Since the intrinsic is not implemented for ARM32, it should be implicitly skipped it in the TemplateInterpreterGenerator::generate_math_entry to avoid ShouldNotReachHere.
Looks fine. I think this is pretty trivial too.
-------------
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21228#pullrequestreview-2334367762
More information about the hotspot-dev
mailing list